Remove Searchfox function search tool#5742
Open
suhaibmujahid wants to merge 2 commits intomozilla:masterfrom
Open
Remove Searchfox function search tool#5742suhaibmujahid wants to merge 2 commits intomozilla:masterfrom
suhaibmujahid wants to merge 2 commits intomozilla:masterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Removes the Searchfox-based find_function_definition MCP tool from the Firefox Development MCP server, per #5741, to reduce redundancy and context/tool surface area.
Changes:
- Removed
find_function_definitionMCP tool and its supportingget_file()/FunctionSearchSearchfoxAPIwiring. - Dropped unused imports related to Searchfox function search.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
marco-c
reviewed
Feb 24, 2026
| - Use available tools when you need to verify concerns or gather additional context | ||
| - Only include comments where you are at least 80% confident the issue is valid | ||
| - When uncertain about an issue, use tools like `find_function_definition` or `expand_context` to verify before commenting | ||
| - When uncertain about an issue, use available tools to verify before commenting |
Collaborator
There was a problem hiding this comment.
Does this mean review helper won't be able to search for now, until it'll be able to use searchfox-cli itself?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #5741